[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothi
From: |
Helge Deller |
Subject: |
[PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display" |
Date: |
Wed, 26 Aug 2020 23:13:41 +0200 |
This reverts commit b0f6455feac97e41045ee394e11c24d92c370f6e.
It's wrong. A line could even be a dot.
Signed-off-by: Helge Deller <deller@gmx.de>
---
hw/display/artist.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 47de17b9e9..f37aa9eb49 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -591,9 +591,6 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
} else {
dy = y1 - y2;
}
- if (!dx || !dy) {
- return;
- }
c1 = false;
if (dy > dx) {
--
2.21.3
- [PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:, Helge Deller, 2020/08/26
- [PULL v5 01/12] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources, Helge Deller, 2020/08/26
- [PULL v5 05/12] hw/hppa/lasi: Don't abort on invalid IMR value, Helge Deller, 2020/08/26
- [PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display",
Helge Deller <=
- [PULL v5 07/12] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run, Helge Deller, 2020/08/26
- [PULL v5 09/12] hw/display/artist: Prevent out of VRAM buffer accesses, Helge Deller, 2020/08/26
- [PULL v5 10/12] hw/display/artist: Unbreak size mismatch memory accesses, Helge Deller, 2020/08/26
- [PULL v5 11/12] hw/display/artist: Fix invalidation of lines in artist_draw_line(), Helge Deller, 2020/08/26
- [PULL v5 12/12] hw/display/artist: Fix invalidation of lines near screen border, Helge Deller, 2020/08/26
- [PULL v5 03/12] hw/hppa: Implement proper SeaBIOS version check, Helge Deller, 2020/08/26
- [PULL v5 06/12] hw/display/artist: Check offset in draw_line to avoid buffer over-run, Helge Deller, 2020/08/26
- [PULL v5 02/12] seabios-hppa: Update to SeaBIOS hppa version 1, Helge Deller, 2020/08/26
- [PULL v5 04/12] hw/display/artist.c: fix out of bounds check, Helge Deller, 2020/08/26
- Re: [PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:, Peter Maydell, 2020/08/27