[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/16] tests: qga has virtio-serial by default when host has
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH 05/16] tests: qga has virtio-serial by default when host has it |
Date: |
Fri, 28 Aug 2020 17:47:14 +0400 |
Hi
On Fri, Aug 28, 2020 at 4:55 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 28/08/2020 13.07, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > When dumping the default configuration, don't expect virtio-serial as
> > the configured method, unless the host has CONFIG_VIRTIO_SERIAL.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > tests/test-qga.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/test-qga.c b/tests/test-qga.c
> > index 4ac4c22109..122730d326 100644
> > --- a/tests/test-qga.c
> > +++ b/tests/test-qga.c
> > @@ -728,10 +728,12 @@ static void test_qga_config(gconstpointer data)
> > g_assert_false(g_key_file_get_boolean(kf, "general", "daemon",
> > &error));
> > g_assert_no_error(error);
> >
> > +#ifdef CONFIG_VIRTIO_SERIAL
> > str = g_key_file_get_string(kf, "general", "method", &error);
> > g_assert_no_error(error);
> > g_assert_cmpstr(str, ==, "virtio-serial");
> > g_free(str);
> > +#endif
> >
> > str = g_key_file_get_string(kf, "general", "path", &error);
> > g_assert_no_error(error);
>
> Does this work as expected? I thought that CONFIG_VIRTIO_SERIAL is a
> *target* specific config switch, not a host specific one ?
You are right, it's basically dead code then. I'll drop this patch for
now, or come up with something better. It was from an earlier attempt
where test-qga was running under !linux. I will try that again.
- [PATCH 00/16] meson: convert unit tests in tests/Makefile.include, marcandre . lureau, 2020/08/28
- [PATCH 01/16] meson: build qapi tests library, marcandre . lureau, 2020/08/28
- [PATCH 02/16] meson: declare tasn1 dependency, marcandre . lureau, 2020/08/28
- [PATCH 03/16] meson: declare keyutils dependency, marcandre . lureau, 2020/08/28
- [PATCH 04/16] meson: convert qht-bench, marcandre . lureau, 2020/08/28
- [PATCH 05/16] tests: qga has virtio-serial by default when host has it, marcandre . lureau, 2020/08/28
- [PATCH 06/16] meson: convert the unit tests, marcandre . lureau, 2020/08/28
- [PATCH 07/16] meson: move keyutils dependency check, marcandre . lureau, 2020/08/28
- [PATCH 08/16] meson: remove old socket_scm_helper rule, marcandre . lureau, 2020/08/28
- [PATCH 09/16] meson: convert vhost-user-bridge, marcandre . lureau, 2020/08/28
- [PATCH 10/16] meson: convert atomic*-bench, marcandre . lureau, 2020/08/28
- [PATCH 11/16] tests/Makefile.include: update check-build, marcandre . lureau, 2020/08/28
- [PATCH 12/16] tests: do not print benchmark output to stdout, marcandre . lureau, 2020/08/28
- [PATCH 13/16] meson: convert the speed tests, marcandre . lureau, 2020/08/28
- [PATCH 14/16] tests/migration/stress: remove unused exit_success, marcandre . lureau, 2020/08/28