[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] meson: install $localstatedir/run for qga
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 5/6] meson: install $localstatedir/run for qga |
Date: |
Sun, 30 Aug 2020 18:14:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 30/08/20 11:44, Paolo Bonzini wrote:
> This doesn't work if /var/run exists and is a symlink:
>
> Installing subdir /home/pbonzini/ff/run to
> /home/pbonzini/ff/build/test/var/local/run
> Traceback (most recent call last):
> File "/usr/lib/python3.8/site-packages/mesonbuild/mesonmain.py", line 131,
> in run
> return options.run_func(options)
> File "/usr/lib/python3.8/site-packages/mesonbuild/minstall.py", line 538,
> in run
> installer.do_install(datafilename)
> File "/usr/lib/python3.8/site-packages/mesonbuild/minstall.py", line 357,
> in do_install
> self.install_subdirs(d) # Must be first, because it needs to delete the
> old subtree.
> File "/usr/lib/python3.8/site-packages/mesonbuild/minstall.py", line 383,
> in install_subdirs
> d.dirmaker.makedirs(full_dst_dir, exist_ok=True)
> File "/usr/lib/python3.8/site-packages/mesonbuild/minstall.py", line 60, in
> makedirs
> os.makedirs(path, exist_ok=exist_ok)
> File "/usr/lib64/python3.8/os.py", line 223, in makedirs
> mkdir(name, mode)
> FileExistsError: [Errno 17] File exists:
> '/home/pbonzini/ff/build/test/var/local/run'
Nevermind, it works in 0.55.1. I'll do a few more tests just to be
sure, but I've queued the series.
Paolo
- [PATCH 0/6] meson: convert the remaining of install target, marcandre . lureau, 2020/08/26
- [PATCH 1/6] meson: install pc-bios blobs, marcandre . lureau, 2020/08/26
- [PATCH 2/6] meson: install scripts/qemu-trace-stap, marcandre . lureau, 2020/08/26
- [PATCH 3/6] meson: install icons, marcandre . lureau, 2020/08/26
- [PATCH 4/6] meson: install desktop file, marcandre . lureau, 2020/08/26
- [PATCH 5/6] meson: install $localstatedir/run for qga, marcandre . lureau, 2020/08/26
- [PATCH 6/6] build-sys: remove install target from Makefile, marcandre . lureau, 2020/08/26