Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

[Richard Henderson]

On 8/30/20 12:48 PM, Taylor Simpson wrote:
> I'll add the following comment to indicate what's going on
> 
> /*
>   * Each of the generated helpers is wrapped with #ifndef fGEN_TCG_<tag>.
>   * For example
>    *     #ifndef fGEN_TCG_A2_add
>    *     DEF_HELPER_3(A2_add, s32, env, s32, s32)
>    *     #endif
>   * We include gen_tcg.h here to provide definitions of fGEN_TCG for any 
> instructions that
>   * are overridden.
>   *
>   * This prevents unused helpers from taking up space in the executable.
>   */

Ah, hum.  Well.

How about we figure out a way to communicate to the generator scripts which
functions have been implemented "directly", and don't need to be generated at 
all?

I don't see why we have to wait until the c preprocessor to remove this unused
code, and the less we have of it, the better.


r~