[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson: use pkg-config method to find dependencies
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] meson: use pkg-config method to find dependencies |
|
Date: |
Mon, 31 Aug 2020 14:15:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 31/08/20 13:06, Gerd Hoffmann wrote:
>
>> Keep "auto" for SDL so that it tries using
>> sdl-config too.
>> - sdl = dependency('sdl2',
>> - required: get_option('sdl'),
>> + sdl = dependency('sdl2', required: get_option('sdl'),
>> + method: 'pkg-config',
> code and commit message mismatch here.
That's docs/devel/build-system.rst, I wanted to keep the "method" so
that people can cut-and-paste correctly.
Would you prefer if I switched from sdl2 to something else (for example
pixman which has a "version" keyword argument as well)?
Paolo