qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 27/76] target/microblaze: Check singlestep_enabled in gen_


From: Richard Henderson
Subject: Re: [PATCH v2 27/76] target/microblaze: Check singlestep_enabled in gen_goto_tb
Date: Mon, 31 Aug 2020 07:55:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 8/31/20 6:54 AM, Edgar E. Iglesias wrote:
>> +        TCGv_i32 tmp = tcg_const_i32(EXCP_DEBUG);
>> +        tcg_gen_movi_i64(cpu_SR[SR_PC], dest);
> 
> This needs to be i32 cpu_pc to avoid breaking bisection. Looks like this
> part slipped over to the next patch.
> 
> With that fixed:
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Whoops, yes.  Thanks.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]