[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot
From: |
Edgar E. Iglesias |
Subject: |
Re: [PATCH 4/6] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot |
Date: |
Tue, 1 Sep 2020 09:02:23 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Aug 31, 2020 at 11:40:16AM -0700, Richard Henderson wrote:
> It is legal to put an mts instruction into a delay slot.
> We should continue to return to the main loop in that
> case so that we recognize any pending interrupts.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/microblaze/translate.c | 34 +++++++++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 9c52448c06..b116a0ce4f 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1696,6 +1696,10 @@ static void mb_tr_translate_insn(DisasContextBase
> *dcb, CPUState *cs)
> dc->base.pc_next += 4;
>
> if (dc->jmp_cond != TCG_COND_NEVER && !(dc->tb_flags & D_FLAG)) {
> + /*
> + * Finish finish any return-from branch.
Typo, 2x finish.
With that fixed:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 4/6] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot,
Edgar E. Iglesias <=