[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurabl
From: |
Richard Henderson |
Subject: |
Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable |
Date: |
Tue, 1 Sep 2020 14:36:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/1/20 11:34 AM, Helge Deller wrote:
> diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
> index 90aeefe2a4..e9d84d0f03 100644
> --- a/hw/hppa/machine.c
> +++ b/hw/hppa/machine.c
> @@ -72,6 +72,14 @@ static FWCfgState *create_fw_cfg(MachineState *ms)
> fw_cfg_add_file(fw_cfg, "/etc/firmware-min-version",
> g_memdup(&val, sizeof(val)), sizeof(val));
>
> + val = cpu_to_le64(HPPA_TLB_ENTRIES);
I guess you don't have a cpu structure here against which you could apply
ARRAY_SIZE?
> /* ??? The number of entries isn't specified by the architecture. */
> + #define HPPA_TLB_ENTRIES 256
> + #define HPPA_BTLB_ENTRIES 0
What's a btlb entry?
The indented defines are weird.
r~
- Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution, (continued)
- Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution, Richard Henderson, 2020/09/02
- Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution, Helge Deller, 2020/09/03
- Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution, Helge Deller, 2020/09/03
- Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution, Helge Deller, 2020/09/03
- Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution, Richard Henderson, 2020/09/03
[PATCH 3/7] hw/hppa: Store boot device in fw_cfg section, Helge Deller, 2020/09/01
[PATCH 1/7] seabios-hppa: Update SeaBIOS to hppa-qemu-5.2-2 tag, Helge Deller, 2020/09/01
[PATCH 7/7] target/hppa: Fix boot with old Linux installation CDs, Helge Deller, 2020/09/01
[PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable, Helge Deller, 2020/09/01
- Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable,
Richard Henderson <=
Re: [PATCH 0/7] hppa power button support, graphics updates and firmware fixes, Philippe Mathieu-Daudé, 2020/09/01