[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS)
From: |
Thomas Huth |
Subject: |
Re: [PATCH] tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS) |
Date: |
Wed, 2 Sep 2020 11:36:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 02/09/2020 10.05, Philippe Mathieu-Daudé wrote:
> Fix an error handling issue reported by Coverity:
>
> /qemu/tests/qtest/ahci-test.c: 1452 in prepare_iso()
> 1444 int fd = mkstemp(cdrom_path);
> >>> CID 1432375: Error handling issues (NEGATIVE_RETURNS)
> >>> "fd" is passed to a parameter that cannot be negative.
> 1452 ret = write(fd, patt, size);
>
> Reported-by: Coverity (CID 1432375)
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/qtest/ahci-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c
> index ca4294f44f3..5e1954852e7 100644
> --- a/tests/qtest/ahci-test.c
> +++ b/tests/qtest/ahci-test.c
> @@ -1443,6 +1443,7 @@ static int prepare_iso(size_t size, unsigned char
> **buf, char **name)
> ssize_t ret;
> int fd = mkstemp(cdrom_path);
>
> + g_assert(fd != -1);
Should be good enough for a qtest.
Reviewed-by: Thomas Huth <thuth@redhat.com>