|
From: | Markus Armbruster |
Subject: | Re: [PATCH] libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref() |
Date: | Wed, 02 Sep 2020 16:31:32 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Thomas Huth <thuth@redhat.com> writes: > On 02/09/2020 13.57, Markus Armbruster wrote: >> qmp_assert_error_class() does more than just assert: it also unrefs >> the @rsp argument. Rename to qmp_assert_error_class() to reduce >> confusion. > > s/to qmp_assert_error_class()/to qmp_expect_error_and_unref()/ I once again demonstrate that I'm unable to read what I wrote myself. > With that nit fixed (I can do it when picking up the patch): > > Acked-by: Thomas Huth <thuth@redhat.com> Thanks!
[Prev in Thread] | Current Thread | [Next in Thread] |