[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 11/15] tests/qtest/ipmi-kcs: Fix assert side-effect
From: |
Thomas Huth |
Subject: |
[PULL v2 11/15] tests/qtest/ipmi-kcs: Fix assert side-effect |
Date: |
Wed, 2 Sep 2020 17:49:28 +0200 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Fix assert side-effect reported by Coverity:
/qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf()
83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) {
>>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFECT)
>>> Argument "--count" of g_assert() has a side effect. The containing
function might work differently in a non-debug build.
84 g_assert(--count != 0);
Reported-by: Coverity (CID 1432368)
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200902080801.160652-2-philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/ipmi-kcs-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/ipmi-kcs-test.c b/tests/qtest/ipmi-kcs-test.c
index 693a6aacb5..fc0a918c8d 100644
--- a/tests/qtest/ipmi-kcs-test.c
+++ b/tests/qtest/ipmi-kcs-test.c
@@ -81,7 +81,8 @@ static void kcs_wait_obf(void)
{
unsigned int count = 1000;
while (IPMI_KCS_CMDREG_GET_OBF() == 0) {
- g_assert(--count != 0);
+ --count;
+ g_assert(count != 0);
}
}
--
2.18.2
- [PULL v2 02/15] cirrus.yml: Compile FreeBSD with -Werror, (continued)
- [PULL v2 02/15] cirrus.yml: Compile FreeBSD with -Werror, Thomas Huth, 2020/09/02
- [PULL v2 03/15] cirrus.yml: Compile macOS with -Werror, Thomas Huth, 2020/09/02
- [PULL v2 01/15] configure: Fix atomic64 test for --enable-werror on macOS, Thomas Huth, 2020/09/02
- [PULL v2 05/15] cirrus.yml: Split FreeBSD job into two parts, Thomas Huth, 2020/09/02
- [PULL v2 08/15] hw/m68k: QOMify the mcf5206 system integration module, Thomas Huth, 2020/09/02
- [PULL v2 09/15] tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS), Thomas Huth, 2020/09/02
- [PULL v2 04/15] cirrus.yml: Update the macOS jobs to Catalina, Thomas Huth, 2020/09/02
- [PULL v2 10/15] tests/qtest/tpm: Declare input buffers const and static, Thomas Huth, 2020/09/02
- [PULL v2 07/15] configure: Add system = 'linux' for meson when cross-compiling, Thomas Huth, 2020/09/02
- [PULL v2 06/15] meson: fix keymaps without qemu-keymap, Thomas Huth, 2020/09/02
- [PULL v2 11/15] tests/qtest/ipmi-kcs: Fix assert side-effect,
Thomas Huth <=
- [PULL v2 12/15] libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref(), Thomas Huth, 2020/09/02
- [PULL v2 13/15] gitlab/travis: Rework the disabled features tests, Thomas Huth, 2020/09/02
- [PULL v2 14/15] gitlab-ci.yml: Run check-qtest and check-unit at the end of the fuzzer job, Thomas Huth, 2020/09/02
- [PULL v2 15/15] gitlab-ci.yml: Set artifacts expiration time, Thomas Huth, 2020/09/02
- Re: [PULL v2 00/15] Cirrus-CI improvements, and other CI-related fixes, m68k, Peter Maydell, 2020/09/02
- Re: [PULL v2 00/15] Cirrus-CI improvements, and other CI-related fixes, m68k, Thomas Huth, 2020/09/03
- Re: [PULL v2 00/15] Cirrus-CI improvements, and other CI-related fixes, m68k, Gerd Hoffmann, 2020/09/03
- Re: [PULL v2 00/15] Cirrus-CI improvements, and other CI-related fixes, m68k, Peter Maydell, 2020/09/03
- Re: [PULL v2 00/15] Cirrus-CI improvements, and other CI-related fixes, m68k, Thomas Huth, 2020/09/03