[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/8] qapi/block-core.json: Remove stale description of 'blockdev-a
From: |
Markus Armbruster |
Subject: |
[PULL 2/8] qapi/block-core.json: Remove stale description of 'blockdev-add' |
Date: |
Thu, 3 Sep 2020 10:23:38 +0200 |
From: Kashyap Chamarthy <kchamart@redhat.com>
On a 'qemu-discuss' thread[1], Kevin identifies that the current doc
blurb for @blockdev-add is stale:
This is actually a documentation bug. @id doesn't exist,
blockdev-add never creates a BlockBackend. This was different in the
very first versions of the patches to add blockdev-add and we
probably just forgot to update the documentation after removing it.
So remove the stale bits.
And the requirement for 'node-name' is already mentioned in the
documentation of @BlockdevOptions:
[...]
# @node-name: the node name of the new node (Since 2.0).
# This option is required on the top level of blockdev-add.
# Valid node names start with an alphabetic character and may
# contain only alphanumeric characters, '-', '.' and '_'. Their
# maximum length is 31 characters.
[...]
[1] https://lists.nongnu.org/archive/html/qemu-discuss/2020-07/msg00071.html
-- equivalent to "-drive if=ide,id=disk0....."
Fixes: be4b67bc7d ("blockdev: Allow creation of BDS trees without BB")
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200805100158.1239390-1-kchamart@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/block-core.json | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index db08c58d78..55b58ba892 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -4036,9 +4036,7 @@
##
# @blockdev-add:
#
-# Creates a new block device. If the @id option is given at the top level, a
-# BlockBackend will be created; otherwise, @node-name is mandatory at the top
-# level and no BlockBackend will be created.
+# Creates a new block device.
#
# Since: 2.9
#
--
2.26.2
- [PULL 0/8] QAPI patches patches for 2020-09-03, Markus Armbruster, 2020/09/03
- [PULL 1/8] qapi: enable use of g_autoptr with QAPI types, Markus Armbruster, 2020/09/03
- [PULL 4/8] scripts/qmp/qom-fuse: Port to current Python module fuse, Markus Armbruster, 2020/09/03
- [PULL 5/8] scripts/qmp/qom-fuse: Fix getattr(), read() for files in /, Markus Armbruster, 2020/09/03
- [PULL 7/8] qapi: Document event VSERPORT_CHANGE is rate-limited, Markus Armbruster, 2020/09/03
- [PULL 8/8] docs/qdev-device-use: Don't suggest -drive and -net can do USB, Markus Armbruster, 2020/09/03
- [PULL 2/8] qapi/block-core.json: Remove stale description of 'blockdev-add',
Markus Armbruster <=
- [PULL 6/8] docs/interop/qmp-spec: Point to the QEMU QMP reference manual, Markus Armbruster, 2020/09/03
- [PULL 3/8] scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol, Markus Armbruster, 2020/09/03
- Re: [PULL 0/8] QAPI patches patches for 2020-09-03, Peter Maydell, 2020/09/05