[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QM
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands |
Date: |
Thu, 3 Sep 2020 11:21:12 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Thu, Sep 03, 2020 at 12:17:29PM +0200, Kevin Wolf wrote:
> Am 03.09.2020 um 11:48 hat Markus Armbruster geschrieben:
> > If having to map from drive ID to node-name really is too much of a
> > burden, we can look for ways to make it easier, or we can make savem
> > optionally accept drive IDs instead of node-names, like we do in several
> > other places for backward compatibility.
>
> Yes, letting commands accept both node-names and drive IDs is trivial
> and we do it pretty much everywhere. Much better than randomly selecting
> an image to save the VM state to.
Is there anything which guarantees that node-names and drive IDs will
never clash ? I didn't look for drive IDs as I was trying to ensure
a non-ambiguous lookup in case a string was both a valid node name
and a valid drive ID
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Markus Armbruster, 2020/09/01
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2020/09/01
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Markus Armbruster, 2020/09/02
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2020/09/02
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Markus Armbruster, 2020/09/03
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Kevin Wolf, 2020/09/03
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands,
Daniel P . Berrangé <=
- Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands, Markus Armbruster, 2020/09/03