[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c |
Date: |
Thu, 3 Sep 2020 12:34:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 03/09/20 12:22, Thomas Huth wrote:
>> Since you didn't remove that conditional, I assume that nothing
>> built in a "if not have_block" scenario was relying on the existing
>> stub ?
Technically there would be a user:
scripts/tracetool/backend/log.py
-> (qemu_get_thread_id) util/oslib-win32.c
which brings in qemu_try_set_nonblock and that calls qemu_fd_register.
Likewise,
util/qht.c
-> (qemu_vfree) util/oslib-win32.c
Windows builds actually don't build anything on a --disable-system
--disable-tools build so it happens to work.
However, as a follow-up qemu_set_block/qemu_try_set_nonblock and
qemu_set_nonblock probably should be moved from util/oslib-* to
util/main-loop.c.
Paolo