[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 53/63] usb: Rename USB_SERIAL_DEV to USB_SERIAL
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 53/63] usb: Rename USB_SERIAL_DEV to USB_SERIAL |
Date: |
Thu, 3 Sep 2020 15:04:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/3/20 12:43 AM, Eduardo Habkost wrote:
> Make the type checking macro name consistent with the TYPE_*
> constant.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Cc: qemu-devel@nongnu.org
> ---
> hw/usb/dev-serial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c
> index 1a58851d4b..1a038a222e 100644
> --- a/hw/usb/dev-serial.c
> +++ b/hw/usb/dev-serial.c
> @@ -113,7 +113,7 @@ struct USBSerialState {
> typedef struct USBSerialState USBSerialState;
>
> #define TYPE_USB_SERIAL "usb-serial-dev"
> -DECLARE_INSTANCE_CHECKER(USBSerialState, USB_SERIAL_DEV,
> +DECLARE_INSTANCE_CHECKER(USBSerialState, USB_SERIAL,
> TYPE_USB_SERIAL)
>
> enum {
> @@ -517,7 +517,7 @@ static void usb_serial_event(void *opaque, QEMUChrEvent
> event)
>
> static void usb_serial_realize(USBDevice *dev, Error **errp)
> {
> - USBSerialState *s = USB_SERIAL_DEV(dev);
> + USBSerialState *s = USB_SERIAL(dev);
> Error *local_err = NULL;
>
> usb_desc_create_serial(dev);
>
- [PATCH 49/63] stm32f205: Rename STM32F2XXTIMER to STM32F2XX_TIMER, (continued)
- [PATCH 49/63] stm32f205: Rename STM32F2XXTIMER to STM32F2XX_TIMER, Eduardo Habkost, 2020/09/02
- [PATCH 48/63] sabre: Rename SABRE_DEVICE to SABRE, Eduardo Habkost, 2020/09/02
- [PATCH 50/63] tpm_crb: Rename CRB to TPM_CRB, Eduardo Habkost, 2020/09/02
- [PATCH 52/63] usb: Rename USB_REDIRECT to USB_REDIR, Eduardo Habkost, 2020/09/02
- [PATCH 51/63] tpm_spapr: Rename VIO_SPAPR_VTPM to TPM_SPAPR, Eduardo Habkost, 2020/09/02
- [PATCH 53/63] usb: Rename USB_SERIAL_DEV to USB_SERIAL, Eduardo Habkost, 2020/09/02
- Re: [PATCH 53/63] usb: Rename USB_SERIAL_DEV to USB_SERIAL,
Philippe Mathieu-Daudé <=
- [PATCH 54/63] usb: Rename USB_STORAGE_DEV to USB_STORAGE, Eduardo Habkost, 2020/09/02
- [PATCH 56/63] vmxnet3: Rename VMXNET3_DEVICE* to VMXNET3*, Eduardo Habkost, 2020/09/02
- [PATCH 55/63] vfio: Rename PCI_VFIO to VFIO_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 58/63] hvf: Rename HVF_STATE to HVF_ACCEL, Eduardo Habkost, 2020/09/02
- [PATCH 57/63] xen: Rename XENBACKEND_DEVICE to XENBACKEND, Eduardo Habkost, 2020/09/02
- [PATCH 60/63] tcg: Rename TCG_STATE to TCG_ACCEL, Eduardo Habkost, 2020/09/02
- [PATCH 61/63] tests: Rename TYPE_DUMMY to TYPE_DUMMY_OBJECT, Eduardo Habkost, 2020/09/02
- [PATCH 62/63] tests: Rename DYNAMIC_TYPE to DYNAMIC_PROPS, Eduardo Habkost, 2020/09/02