[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/63] i8259: Rename TYPE_I8259 to TYPE_PIC
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 15/63] i8259: Rename TYPE_I8259 to TYPE_PIC |
Date: |
Thu, 3 Sep 2020 17:45:18 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Thu, Sep 03, 2020 at 12:19:46PM -0400, Eduardo Habkost wrote:
> On Thu, Sep 03, 2020 at 02:47:33PM +0200, Philippe Mathieu-Daudé wrote:
> > On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > > This will make the type name constant consistent with the name of
> > > the type checking macro.
> > >
> > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > > ---
> > > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > > Cc: qemu-devel@nongnu.org
> > > ---
> > > hw/intc/i8259.c | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> > > index 344fd04db1..e536cc90be 100644
> > > --- a/hw/intc/i8259.c
> > > +++ b/hw/intc/i8259.c
> > > @@ -37,10 +37,10 @@
> > >
> > > //#define DEBUG_IRQ_LATENCY
> > >
> > > -#define TYPE_I8259 "isa-i8259"
> > > +#define TYPE_PIC "isa-i8259"
> >
> > I disagree with this patch, as we have various PIC and only one I8259.
>
> Like in the I8254 case, I agree with your point. I will suggest
> renaming the PIC macro to I8259 instead.
I'd suggest it should be TYPE_ISA_I8259 to match the object type name
string.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, (continued)
- [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Eduardo Habkost, 2020/09/02
- Re: [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Philippe Mathieu-Daudé, 2020/09/03
- Re: [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Eduardo Habkost, 2020/09/03
- Re: [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Daniel P . Berrangé, 2020/09/03
- Re: [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Eduardo Habkost, 2020/09/03
- Re: [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Philippe Mathieu-Daudé, 2020/09/03
- Re: [PATCH 14/63] i8254: Rename TYPE_I8254 to TYPE_PIT, Eduardo Habkost, 2020/09/03
[PATCH 15/63] i8259: Rename TYPE_I8259 to TYPE_PIC, Eduardo Habkost, 2020/09/02
[PATCH 16/63] i8259: Rename TYPE_KVM_I8259 to TYPE_KVM_PIC, Eduardo Habkost, 2020/09/02
[PATCH 17/63] intel-hda: Rename TYPE_INTEL_HDA_GENERIC to TYPE_INTEL_HDA, Eduardo Habkost, 2020/09/02
[PATCH 20/63] pc87312: Rename TYPE_PC87312_SUPERIO to TYPE_PC87312, Eduardo Habkost, 2020/09/02