[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/8] crypto: fix build with gcrypt enabled
From: |
Richard Henderson |
Subject: |
Re: [PATCH v1 2/8] crypto: fix build with gcrypt enabled |
Date: |
Thu, 3 Sep 2020 12:02:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/3/20 4:21 AM, Alex Bennée wrote:
> From: Daniel P. Berrangé <berrange@redhat.com>
>
> If nettle is disabled and gcrypt enabled, the compiler and linker flags
> needed for gcrypt are not passed.
>
> Gnutls was also not added as a dependancy when gcrypt is enabled.
>
> Attempting to add the library dependencies at the same time as the
> source dependencies is error prone, as there are alot of different
> rules for picking which sources to use, and some of the source files
> use code level conditionals intead. It is thus clearer to add the
> library dependencies separately.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200901133050.381844-2-berrange@redhat.com>
> ---
> configure | 2 ++
> crypto/meson.build | 42 +++++++++++++++++++++++++++++++-----------
> meson.build | 5 +++++
> 3 files changed, 38 insertions(+), 11 deletions(-)
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v1 0/8] some testing and CI updates (re-greening), Alex Bennée, 2020/09/03
- [PATCH v1 1/8] CODING_STYLE.rst: flesh out our naming conventions., Alex Bennée, 2020/09/03
- [PATCH v1 2/8] crypto: fix build with gcrypt enabled, Alex Bennée, 2020/09/03
- Re: [PATCH v1 2/8] crypto: fix build with gcrypt enabled,
Richard Henderson <=
- [PATCH v1 3/8] tests/docker: add python3-setuptools the docker images, Alex Bennée, 2020/09/03
- [PATCH v1 4/8] usb-host: restrict workaround to new libusb versions, Alex Bennée, 2020/09/03
- [PATCH v1 5/8] qemu-iotests: move check-block back to Makefiles, Alex Bennée, 2020/09/03
- [PATCH v1 8/8] migration: use pstrcpy to copy run state, Alex Bennée, 2020/09/03
- [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG, Alex Bennée, 2020/09/03