|
From: | Markus Armbruster |
Subject: | Re: [PATCH v6 1/8] monitor: simplify functions for getting a dup'd fdset entry |
Date: | Fri, 04 Sep 2020 09:33:15 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> writes: > Currently code has to call monitor_fdset_get_fd, then dup > the return fd, and then add the duplicate FD back into the > fdset. This dance is overly verbose for the caller and > introduces extra failure modes which can be avoided by > folding all the logic into monitor_fdset_dup_fd_add and > removing monitor_fdset_get_fd entirely. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |