[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to min
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes |
Date: |
Sat, 5 Sep 2020 23:36:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/4/20 9:08 PM, Richard Henderson wrote:
> Sort the elements by type and size, removing a number of holes
> and reducing the size of the entire struct.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/microblaze/cpu.h | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h
> index 59d2a079c4..4d53345f23 100644
> --- a/target/microblaze/cpu.h
> +++ b/target/microblaze/cpu.h
> @@ -293,13 +293,22 @@ struct CPUMBState {
>
> /*
> * Microblaze Configuration Settings
> + *
> + * Note that the structure is sorted by type and size to minimize holes.
> */
> typedef struct {
> - bool stackprot;
> + char *version;
> +
> uint32_t base_vectors;
> + uint32_t pvr_user2;
> +
> uint8_t addr_size;
> uint8_t use_fpu;
> uint8_t use_hw_mul;
> + uint8_t pvr_user1;
> + uint8_t pvr;
> +
> + bool stackprot;
> bool use_barrel;
> bool use_div;
> bool use_msr_instr;
> @@ -313,10 +322,6 @@ typedef struct {
> bool opcode_0_illegal;
> bool div_zero_exception;
> bool unaligned_exceptions;
> - uint8_t pvr_user1;
> - uint32_t pvr_user2;
> - char *version;
> - uint8_t pvr;
> } MicroBlazeCPUConfig;
>
> /**
>
- [PATCH v3 06/19] target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP, (continued)
- [PATCH v3 06/19] target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP, Richard Henderson, 2020/09/04
- [PATCH v3 05/19] target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT, Richard Henderson, 2020/09/04
- [PATCH v3 07/19] target/microblaze: Replace cpustate_changed with DISAS_EXIT_NEXT, Richard Henderson, 2020/09/04
- [PATCH v3 08/19] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot, Richard Henderson, 2020/09/04
- [PATCH v3 10/19] target/microblaze: Use tcg_gen_lookup_and_goto_ptr, Richard Henderson, 2020/09/04
- [PATCH v3 09/19] target/microblaze: Force rtid, rted, rtbd to exit, Richard Henderson, 2020/09/04
- [PATCH v3 11/19] target/microblaze: Diagnose invalid insns in delay slots, Richard Henderson, 2020/09/04
- [PATCH v3 12/19] target/microblaze: Split out MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes, Richard Henderson, 2020/09/04
- Re: [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes,
Philippe Mathieu-Daudé <=
- [PATCH v3 14/19] target/microblaze: Move pvr regs to MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 15/19] target/microblaze: Treat pvr_regs as constant, Richard Henderson, 2020/09/04
- [PATCH v3 18/19] target/microblaze: Put MicroBlazeCPUConfig into DisasContext, Richard Henderson, 2020/09/04
- [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig, Richard Henderson, 2020/09/04
- [PATCH v3 17/19] target/microblaze: Fill in VMStateDescription for cpu, Richard Henderson, 2020/09/04
- [PATCH v3 19/19] configure: Do not set TARGET_ABI32 for microblaze, Richard Henderson, 2020/09/04
- Re: [PATCH v3 00/19] target/microblaze improvements, Edgar E. Iglesias, 2020/09/07