[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/14] tests: Fixes building test-util-filemonitor.c on msys2/ming
From: |
Thomas Huth |
Subject: |
[PULL 04/14] tests: Fixes building test-util-filemonitor.c on msys2/mingw |
Date: |
Mon, 7 Sep 2020 14:11:17 +0200 |
From: Yonggang Luo <luoyonggang@gmail.com>
Fixes the following compiling error:
../tests/test-util-filemonitor.c: In function 'test_file_monitor_events':
../tests/test-util-filemonitor.c:620:17: error: too many arguments to function
'mkdir'
620 | if (mkdir(pathsrc, 0700) < 0) {
| ^~~~~
In file included from
C:/CI-Tools/msys64/mingw64/x86_64-w64-mingw32/include/unistd.h:10,
from C:/work/xemu/qemu/include/qemu/osdep.h:93,
from ../tests/test-util-filemonitor.c:21:
C:/CI-Tools/msys64/mingw64/x86_64-w64-mingw32/include/io.h:282:15: note:
declared here
282 | int __cdecl mkdir (const char *) __MINGW_ATTRIB_DEPRECATED_MSVC2005;
| ^~~~~
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Message-Id: <20200905203425.1470-1-luoyonggang@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/test-util-filemonitor.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/test-util-filemonitor.c b/tests/test-util-filemonitor.c
index 8f0eff3d03..b629e10857 100644
--- a/tests/test-util-filemonitor.c
+++ b/tests/test-util-filemonitor.c
@@ -23,6 +23,8 @@
#include "qapi/error.h"
#include "qemu/filemonitor.h"
+#include <glib/gstdio.h>
+
#include <utime.h>
enum {
@@ -617,7 +619,7 @@ test_file_monitor_events(void)
if (debug) {
g_printerr("Mkdir %s\n", pathsrc);
}
- if (mkdir(pathsrc, 0700) < 0) {
+ if (g_mkdir_with_parents(pathsrc, 0700) < 0) {
g_printerr("Unable to mkdir %s: %s",
pathsrc, strerror(errno));
goto cleanup;
--
2.18.2
- [PULL 00/14] Gitlab-CI improvements and related fixes, Thomas Huth, 2020/09/07
- [PULL 01/14] tests/docker: add python3-setuptools the docker images, Thomas Huth, 2020/09/07
- [PULL 02/14] tests: handling signal on win32 properly, Thomas Huth, 2020/09/07
- [PULL 03/14] tests: fixes test-vmstate.c compile error on msys2, Thomas Huth, 2020/09/07
- [PULL 05/14] tests/Makefile: test-image-locking needs CONFIG_POSIX, Thomas Huth, 2020/09/07
- [PULL 04/14] tests: Fixes building test-util-filemonitor.c on msys2/mingw,
Thomas Huth <=
- [PULL 06/14] dockerfiles/debian-win64-cross: Download WHPX MinGW headers, Thomas Huth, 2020/09/07
- [PULL 07/14] configure: Allow automatic WHPX detection, Thomas Huth, 2020/09/07
- [PULL 08/14] stubs: Move qemu_timer_notify_cb() and remove qemu_notify_event() stub, Thomas Huth, 2020/09/07
- [PULL 10/14] gitlab-ci: Add cross-compiling build tests, Thomas Huth, 2020/09/07
- [PULL 11/14] crypto: fix build with gcrypt enabled, Thomas Huth, 2020/09/07
- [PULL 12/14] gitlab: expand test coverage for crypto builds, Thomas Huth, 2020/09/07
- [PULL 13/14] tests/qtest: do not list ahci-test twice, Thomas Huth, 2020/09/07
- [PULL 14/14] target/microblaze: Collected fixes for env->iflags, Thomas Huth, 2020/09/07
- [PULL 09/14] stubs: Move qemu_fd_register stub to util/main-loop.c, Thomas Huth, 2020/09/07
- Re: [PULL 00/14] Gitlab-CI improvements and related fixes, Yonggang Luo, 2020/09/07