[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] qapi: A section heading bug fix, and maybe an improvemen
From: |
Peter Maydell |
Subject: |
Re: [PATCH 0/2] qapi: A section heading bug fix, and maybe an improvement |
Date: |
Mon, 7 Sep 2020 15:53:58 +0100 |
On Mon, 7 Sep 2020 at 15:41, Markus Armbruster <armbru@redhat.com> wrote:
>
> Markus Armbruster <armbru@redhat.com> writes:
>
> > PATCH 1 fixes an old defect in the doc comment parser. I figure it'll
> > simplify the rST generator's job.
> >
> > PATCH 2 might simplify it further. It's RFC because I'm not sure it
> > does. Peter, you tell me :)
>
> I dropped the ball on this one. I think both patches make sense, but I
> don't want to upset Peter's "Convert QAPI doc comments to generate rST
> instead of texinfo" apple cart. Peter, please tell me what you'd like
> me to do:
>
> * Post a pull request, so you can base your v6 on it.
Looking back at my comments on the patches I think I was happy
with both and it probably isn't a huge rebase issue, so you
might as well send these in a pullreq. You might consider also
including the first 3 patches from my v5 series, which are just
fixing markup issues in the .json that get detected by the
rst conversion.
thanks
-- PMM