[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson.build: tweak sdl-image error message
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] meson.build: tweak sdl-image error message |
Date: |
Tue, 8 Sep 2020 09:49:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/8/20 9:40 AM, Sergei Trofimovich wrote:
> Before the change missing SDL was reported as:
>
> ../meson.build:253:4: ERROR: Expected 1 arguments, got 2.
>
> After the error as:
>
> ../meson.build:258:4: ERROR: Problem encountered: sdl-image required, but
> SDL was not found
>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> CC: "Philippe Mathieu-Daudé" <philmd@redhat.com>
> CC: Rafael Kitover <rkitover@gmail.com>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 04e070bb3b..7fd2a903c5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -255,8 +255,8 @@ if sdl.found()
> method: 'pkg-config', static: enable_static)
> else
> if get_option('sdl_image').enabled()
> - error('sdl-image required, but SDL was @0@',
> - get_option('sdl').disabled() ? 'disabled' : 'not found')
> + error('sdl-image required, but SDL was @0@'.format(
> + get_option('sdl').disabled() ? 'disabled' : 'not found'))
> endif
> sdl_image = not_found
> endif
>