[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/16] Msys2 patches patches
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 00/16] Msys2 patches patches |
Date: |
Tue, 8 Sep 2020 21:09:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/8/20 8:56 PM, Eric Blake wrote:
> On 9/8/20 1:49 PM, Yonggang Luo wrote:
>> The following changes since commit
>> 6779038537360e957dbded830f76b08ef5070161:
>>
>> Merge remote-tracking branch
>> 'remotes/armbru/tags/pull-qapi-2020-09-08' int=
>> o staging (2020-09-08 17:23:31 +0100)
>>
>> are available in the Git repository at:
>>
>> http://github.com/lygstate/qemu tags/msys2-patches-pull-request
>>
>> for you to fetch changes up to 1892e4360f55ac8cbeeeae0043e0a9dc05c50269:
>>
>> rcu: add uninit destructor for rcu (2020-09-09 02:34:59 +0800)
>>
>> ----------------------------------------------------------------
>> msys2 patch queue 2020-09-09
>
> MAINTAINERS doesn't mention a category for msys2, and this patch series
> doesn't add one. It is unusual to send a pull request without being a
> listed maintainer for the code in question. I'm not objecting to you
> taking on a maintainership role, if we are ready for that, but I also
> worry that you have so few contributions currently in the main
> repository that you have not necessarily proven the quality of your
> work. Maybe it's better to just send this as an ordinary patch series,
> and let an existing maintainer incorporate it?
Beside what Eric said, you sent all your patches altogether, this is
already an improvement for reviewers, thanks!
- [PULL 08/16] block: get file-win32.c handle locking option consistence with file-posix.c, (continued)
- [PULL 08/16] block: get file-win32.c handle locking option consistence with file-posix.c, Yonggang Luo, 2020/09/08
- [PULL 09/16] osdep: These function are only available on Non-Win32 system., Yonggang Luo, 2020/09/08
- [PULL 10/16] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Yonggang Luo, 2020/09/08
- [PULL 11/16] meson: disable crypto tests are empty under win32, Yonggang Luo, 2020/09/08
- [PULL 12/16] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/08
- [PULL 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/08
- [PULL 14/16] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/08
- [PULL 15/16] logging: Fixes memory leak in test-logging.c, Yonggang Luo, 2020/09/08
- [PULL 16/16] rcu: add uninit destructor for rcu, Yonggang Luo, 2020/09/08
- Re: [PULL 00/16] Msys2 patches patches, Eric Blake, 2020/09/08