[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/6] migration: Properly destroy variables on incoming side
From: |
Peter Xu |
Subject: |
[PATCH v2 1/6] migration: Properly destroy variables on incoming side |
Date: |
Tue, 8 Sep 2020 16:30:17 -0400 |
In migration_incoming_state_destroy(), we've got a few variables that aren't
destroyed properly, namely:
main_thread_load_event
postcopy_pause_sem_dst
postcopy_pause_sem_fault
rp_mutex
Destroy them properly.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 58a5452471..749d9b145b 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -238,12 +238,15 @@ void migration_incoming_state_destroy(void)
mis->postcopy_remote_fds = NULL;
}
- qemu_event_reset(&mis->main_thread_load_event);
-
if (mis->socket_address_list) {
qapi_free_SocketAddressList(mis->socket_address_list);
mis->socket_address_list = NULL;
}
+
+ qemu_event_destroy(&mis->main_thread_load_event);
+ qemu_sem_destroy(&mis->postcopy_pause_sem_dst);
+ qemu_sem_destroy(&mis->postcopy_pause_sem_fault);
+ qemu_mutex_destroy(&mis->rp_mutex);
}
static void migrate_generate_event(int new_state)
--
2.26.2
- [PATCH v2 0/6] migration/postcopy: Sync faulted addresses after network recovered, Peter Xu, 2020/09/08
- [PATCH v2 1/6] migration: Properly destroy variables on incoming side,
Peter Xu <=
- [PATCH v2 2/6] migration: Rework migrate_send_rp_req_pages() function, Peter Xu, 2020/09/08
- [PATCH v2 6/6] migration: Sync requested pages after postcopy recovery, Peter Xu, 2020/09/08
- [PATCH v2 5/6] migration: Maintain postcopy faulted addresses, Peter Xu, 2020/09/08
- [PATCH v2 4/6] migration: Introduce migrate_send_rp_message_req_pages(), Peter Xu, 2020/09/08
- [PATCH v2 3/6] migration: Pass incoming state into qemu_ufd_copy_ioctl(), Peter Xu, 2020/09/08
- Re: [PATCH v2 0/6] migration/postcopy: Sync faulted addresses after network recovered, Dr. David Alan Gilbert, 2020/09/23