[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GU
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 1/2] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GUEST_ERROR) |
Date: |
Wed, 9 Sep 2020 15:27:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 01/09/2020 à 12:42, Philippe Mathieu-Daudé a écrit :
> Replace fprintf() by qemu_log_mask(LOG_GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/gpio/omap_gpio.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c
> index f662c4cb958..e25084b40c9 100644
> --- a/hw/gpio/omap_gpio.c
> +++ b/hw/gpio/omap_gpio.c
> @@ -392,8 +392,10 @@ static void omap2_gpio_module_write(void *opaque, hwaddr
> addr,
> break;
>
> case 0x10: /* GPIO_SYSCONFIG */
> - if (((value >> 3) & 3) == 3)
> - fprintf(stderr, "%s: bad IDLEMODE value\n", __func__);
> + if (((value >> 3) & 3) == 3) {
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "%s: Illegal IDLEMODE value: 3\n", __func__);
> + }
> if (value & 2)
> omap2_gpio_module_reset(s);
> s->config[0] = value & 0x1d;
>
Applied to my trivial-patches branch.
Thanks,
Laurent