[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG |
Date: |
Wed, 9 Sep 2020 19:24:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/9/20 10:36 AM, Dov Murik wrote:
> Fix several compiler errors when compiling withe -DHPET_DEBUG.
>
> Steps to reproduce the issue:
>
> mkdir build
> cd build
> ../configure --target-list=x86_64-softmmu --extra-cflags=-DHPET_DEBUG
> make
>
> Dov Murik (2):
> hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw
> hw/timer/hpet: Fix debug format strings
>
> hw/timer/hpet.c | 27 +++++++--------------------
> 1 file changed, 7 insertions(+), 20 deletions(-)
>
I sent almost the same patches last week :)
https://www.mail-archive.com/qemu-devel@nongnu.org/msg736836.html
You seem to fix a 4th format, can you rebase on top? (As these
patches have already been queued).
Glad to see you are interested in debugging the HPET too.
Regards,
Phil.