[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/29] block/export: Add 'id' option to block-export-add
From: |
Max Reitz |
Subject: |
Re: [PATCH 18/29] block/export: Add 'id' option to block-export-add |
Date: |
Thu, 10 Sep 2020 15:26:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 07.09.20 20:20, Kevin Wolf wrote:
> We'll need an id to identify block exports in monitor commands. This
> adds one.
>
> Note that this is different from the 'name' option in the NBD server,
> which is the externally visible export name. While block export ids need
> to be unique in the whole process, export names must be unique only for
> the same server. Different export types or (potentially in the future)
> multiple NBD servers can have the same export name externally, but still
> need different block export ids internally.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-export.json | 5 +++++
> include/block/export.h | 3 +++
> block/export/export.c | 26 ++++++++++++++++++++++++++
> blockdev-nbd.c | 1 +
> qemu-nbd.c | 1 +
> storage-daemon/qemu-storage-daemon.c | 2 +-
> tests/qemu-iotests/223.out | 4 ++--
> 7 files changed, 39 insertions(+), 3 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 16/29] block/export: Allocate BlockExport in blk_exp_add(), (continued)
- [PATCH 15/29] block/export: Add node-name to BlockExportOptions, Kevin Wolf, 2020/09/07
- [PATCH 17/29] block/export: Add blk_exp_close_all(_type), Kevin Wolf, 2020/09/07
- [PATCH 19/29] block/export: Move strong user reference to block_exports, Kevin Wolf, 2020/09/07
- [PATCH 20/29] block/export: Add block-export-del, Kevin Wolf, 2020/09/07
- [PATCH 18/29] block/export: Add 'id' option to block-export-add, Kevin Wolf, 2020/09/07
- Re: [PATCH 18/29] block/export: Add 'id' option to block-export-add,
Max Reitz <=
- [PATCH 21/29] block/export: Add BLOCK_EXPORT_DELETED event, Kevin Wolf, 2020/09/07
- [PATCH 23/29] block/export: Create BlockBackend in blk_exp_add(), Kevin Wolf, 2020/09/07
- [PATCH 24/29] block/export: Add query-block-exports, Kevin Wolf, 2020/09/07
- [PATCH 22/29] block/export: Move blk to BlockExport, Kevin Wolf, 2020/09/07
- [PATCH 25/29] block/export: Move writable to BlockExportOptions, Kevin Wolf, 2020/09/07