[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] pc-bios: refresh edk2 build artifacts for edk2-stable2
From: |
Laszlo Ersek |
Subject: |
Re: [PATCH 08/10] pc-bios: refresh edk2 build artifacts for edk2-stable202008 |
Date: |
Thu, 10 Sep 2020 19:16:37 +0200 |
On 09/10/20 18:32, Philippe Mathieu-Daudé wrote:
> +GitLab team & Gerd (for building firmwares)
>
> On 9/8/20 9:29 AM, Laszlo Ersek wrote:
>> Rebuild the pc-bios/edk2-*.fd.bz2 binaries, based on the edk2-stable202008
>> release.
>>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Ref: https://bugs.launchpad.net/qemu/+bug/1852196
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> pc-bios/edk2-aarch64-code.fd.bz2 | Bin 1178070 -> 1507722 bytes
>> pc-bios/edk2-arm-code.fd.bz2 | Bin 1172752 -> 1503187 bytes
>> pc-bios/edk2-i386-code.fd.bz2 | Bin 1736199 -> 1646741 bytes
>> pc-bios/edk2-i386-secure-code.fd.bz2 | Bin 1943949 -> 1860546 bytes
>> pc-bios/edk2-x86_64-code.fd.bz2 | Bin 1717094 -> 1680164 bytes
>> pc-bios/edk2-x86_64-secure-code.fd.bz2 | Bin 1958037 -> 1912112 bytes
>> 6 files changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/pc-bios/edk2-aarch64-code.fd.bz2
>> b/pc-bios/edk2-aarch64-code.fd.bz2
>> index a074085b224f..5bf311464a79 100644
>> Binary files a/pc-bios/edk2-aarch64-code.fd.bz2 and
>> b/pc-bios/edk2-aarch64-code.fd.bz2 differ
>> diff --git a/pc-bios/edk2-arm-code.fd.bz2 b/pc-bios/edk2-arm-code.fd.bz2
>> index 42453cd1f273..7a98069814dc 100644
>> Binary files a/pc-bios/edk2-arm-code.fd.bz2 and
>> b/pc-bios/edk2-arm-code.fd.bz2 differ
>> diff --git a/pc-bios/edk2-i386-code.fd.bz2 b/pc-bios/edk2-i386-code.fd.bz2
>> index 633759688e32..e7b1befe2cfe 100644
>> Binary files a/pc-bios/edk2-i386-code.fd.bz2 and
>> b/pc-bios/edk2-i386-code.fd.bz2 differ
>> diff --git a/pc-bios/edk2-i386-secure-code.fd.bz2
>> b/pc-bios/edk2-i386-secure-code.fd.bz2
>> index df27bdd2ddbd..b5df5bed3086 100644
>> Binary files a/pc-bios/edk2-i386-secure-code.fd.bz2 and
>> b/pc-bios/edk2-i386-secure-code.fd.bz2 differ
>> diff --git a/pc-bios/edk2-x86_64-code.fd.bz2
>> b/pc-bios/edk2-x86_64-code.fd.bz2
>> index 0e108fc68a91..e1654d4003b7 100644
>> Binary files a/pc-bios/edk2-x86_64-code.fd.bz2 and
>> b/pc-bios/edk2-x86_64-code.fd.bz2 differ
>> diff --git a/pc-bios/edk2-x86_64-secure-code.fd.bz2
>> b/pc-bios/edk2-x86_64-secure-code.fd.bz2
>> index 522f8376aabe..767274c38c7f 100644
>> Binary files a/pc-bios/edk2-x86_64-secure-code.fd.bz2 and
>> b/pc-bios/edk2-x86_64-secure-code.fd.bz2 differ
>>
>
> Now I remember why I kept that patch on hold.
>
> The CI idea is to have reproducible builds if possible.
> When the submodule is updated (or the QEMU scripts containing the
> -D defines), it triggers the 'build-edk2' job which produce these
> same binaries.
> My original idea was to push the tag on GitLab that triggers the
> job, then download the produced binaries, test them, then commit
> them.
>
> With your series, I get these binaries:
> https://gitlab.com/philmd/qemu/-/jobs/731618363/artifacts/browse/pc-bios/
>
> However they differ with yours, for example:
>
> 0000 6100: 00 00 00 00 00 00 00 00 00 00 00 00 2F 68 6F 6D ........
> ..../hom
> 0000 6110: 65 2F 6C 61 63 6F 73 2F 73 72 63 2F 75 70 73 74 e/lacos/
> src/upst
> 0000 6120: 72 65 61 6D 2F 71 65 6D 75 2F 72 6F 6D 73 2F 65 ream/qem
> u/roms/e
> 0000 6130: 64 6B 32 2F 42 75 69 6C 64 2F 41 72 6D 56 69 72 dk2/Buil
> d/ArmVir
> 0000 6140: 74 51 65 6D 75 2D 41 41 52 43 48 36 34 2F 44 45 tQemu-AA
> RCH64/DE
> 0000 6150: 42 55 47 5F 47 43 43 35 2F 41 41 52 43 48 36 34 BUG_GCC5
> /AARCH64
> 0000 6160: 2F 41 72 6D 50 6C 61 74 66 6F 72 6D 50 6B 67 2F /ArmPlat
> formPkg/
> 0000 6170: 50 72 65 50 65 69 43 6F 72 65 2F 50 72 65 50 65 PrePeiCo
> re/PrePe
> 0000 6180: 69 43 6F 72 65 55 6E 69 43 6F 72 65 2F 44 45 42 iCoreUni
> Core/DEB
> 0000 6190: 55 47 2F 41 72 6D 50 6C 61 74 66 6F 72 6D 50 72 UG/ArmPl
> atformPr
> 0000 61A0: 65 50 65 69 43 6F 72 65 2E 64 6C 6C 00 00 00 00 ePeiCore
> .dll....
>
> 0000 6100: 00 00 00 00 00 00 00 00 00 00 00 00 2F 62 75 69 ........
> ..../bui
> 0000 6110: 6C 64 73 2F 70 68 69 6C 6D 64 2F 71 65 6D 75 2F lds/phil
> md/qemu/
> 0000 6120: 72 6F 6D 73 2F 65 64 6B 32 2F 42 75 69 6C 64 2F roms/edk
> 2/Build/
> 0000 6130: 41 72 6D 56 69 72 74 51 65 6D 75 2D 41 41 52 43 ArmVirtQ
> emu-AARC
> 0000 6140: 48 36 34 2F 44 45 42 55 47 5F 47 43 43 35 2F 41 H64/DEBU
> G_GCC5/A
> 0000 6150: 41 52 43 48 36 34 2F 41 72 6D 50 6C 61 74 66 6F ARCH64/A
> rmPlatfo
> 0000 6160: 72 6D 50 6B 67 2F 50 72 65 50 65 69 43 6F 72 65 rmPkg/Pr
> ePeiCore
> 0000 6170: 2F 50 72 65 50 65 69 43 6F 72 65 55 6E 69 43 6F /PrePeiC
> oreUniCo
> 0000 6180: 72 65 2F 44 45 42 55 47 2F 41 72 6D 50 6C 61 74 re/DEBUG
> /ArmPlat
> 0000 6190: 66 6F 72 6D 50 72 65 50 65 69 43 6F 72 65 2E 64 formPreP
> eiCore.d
> 0000 61A0: 6C 6C 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ll......
> ........
>
> For now this is not a blocker, but we should consider switching to
> this workflow at some point (caring about all the files that really
> need to be archived, maybe debug symbols etc...).
Yes, I remember the related discussion from last time.
When preparing this patch set, I didn't know where we stood on that, so
I fully expected that this patch could be dropped, and the remotely
built binaries would be merged instead.
But I wasn't sure either way, so I did build the binaries on my end (I
had to do that anyway for actually testing the other patches, and the
resultant binaries too!), and then I just included them in the mailing
list posting / topic branch.
> w.r.t. your patch:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
Laszlo
- [PATCH 04/10] tests: acpi: tolerate "virt/SSDT.memhp" mismatch temporarily, (continued)
[PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Laszlo Ersek, 2020/09/08
- Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Philippe Mathieu-Daudé, 2020/09/08
- Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Laszlo Ersek, 2020/09/08
- Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Philippe Mathieu-Daudé, 2020/09/10
- Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Laszlo Ersek, 2020/09/10
- Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Philippe Mathieu-Daudé, 2020/09/10
- Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008, Laszlo Ersek, 2020/09/10