[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles
From: |
Paolo Bonzini |
Subject: |
Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles |
Date: |
Fri, 11 Sep 2020 13:17:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 11/09/20 12:58, Max Reitz wrote:
> It seems like the socket_scm_helper is now only built as a dependency of
> check-block, instead of all the time. That’s a bit of a shame.
> (The obvious workaround of course is to specifically build the
> socket_scm_helper, but that doesn’t seem right.)
Or just remove the build_by_default: false here:
socket_scm_helper = executable('socket_scm_helper', 'socket_scm_helper.c',
build_by_default: false)
I guess now is a good time to decide which executables to build by
default (static_libraries should never be built by default) and
document it in docs/devel/build-system.rst.
Right now, the only executables that aren't built by default are:
- rdmacm-mux and vhost-user-blk because they're broken
- gen-features because it's built anyway for s390 targets
- vhost-user-bridge, and that probably should be changed
- socket_scm_helper, which could/should be changed too
- fptest, not sure why that works at all O:-) Tests are built by
default (and they trigger coverity quite a bit). We will be
able to fix that, and at the same time respect the "tests(depends: ...)"
argument instead of just having "check: all", when meson 0.56.0
comes out.
Paolo
signature.asc
Description: OpenPGP digital signature