[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/7] hw/char/serial: Rename I/O read/write trace events
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 4/7] hw/char/serial: Rename I/O read/write trace events |
Date: |
Sat, 12 Sep 2020 13:40:37 +0200 |
The serial_mm_read/write() handlers from the TYPE_SERIAL_MM device
call the serial_ioport_read/write() handlers with shifted offset.
When looking at the trace events from this MMIO device, it is
confusing to read the accesses as I/O. Simplify using generic
trace event names which make sense the various uses.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/char/serial.c | 4 ++--
hw/char/trace-events | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index 1e70294f28a..ade4adfd526 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -333,7 +333,7 @@ static void serial_ioport_write(void *opaque, hwaddr addr,
uint64_t val,
SerialState *s = opaque;
assert(size == 1 && addr < 8);
- trace_serial_ioport_write(addr, val);
+ trace_serial_write(addr, val);
switch(addr) {
default:
case 0:
@@ -550,7 +550,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr
addr, unsigned size)
ret = s->scr;
break;
}
- trace_serial_ioport_read(addr, ret);
+ trace_serial_read(addr, ret);
return ret;
}
diff --git a/hw/char/trace-events b/hw/char/trace-events
index 17304bef26d..609df10fed4 100644
--- a/hw/char/trace-events
+++ b/hw/char/trace-events
@@ -5,8 +5,8 @@ parallel_ioport_read(const char *desc, uint16_t addr, uint8_t
value) "read [%s]
parallel_ioport_write(const char *desc, uint16_t addr, uint8_t value) "write
[%s] addr 0x%02x val 0x%02x"
# serial.c
-serial_ioport_read(uint16_t addr, uint8_t value) "read addr 0x%02x val 0x%02x"
-serial_ioport_write(uint16_t addr, uint8_t value) "write addr 0x%02x val
0x%02x"
+serial_read(uint16_t addr, uint8_t value) "read addr 0x%02x val 0x%02x"
+serial_write(uint16_t addr, uint8_t value) "write addr 0x%02x val 0x%02x"
serial_update_parameters(uint64_t baudrate, char parity, int data_bits, int
stop_bits) "baudrate=%"PRIu64" parity='%c' data=%d stop=%d"
# virtio-serial-bus.c
--
2.26.2
- [PATCH v2 0/7] hw/char/serial: Housekeeping, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 1/7] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 6/7] hw/char/serial: Alias QDEV properties from generic serial object, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 3/7] hw/char/serial: Remove old DEBUG_SERIAL commented code, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 4/7] hw/char/serial: Rename I/O read/write trace events,
Philippe Mathieu-Daudé <=
- [PATCH v2 2/7] hw/char/serial: Replace commented DPRINTF() by trace event, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 7/7] hw/char/serial: Let SerialState have an 'id' field, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 5/7] hw/char/serial: Make 'wakeup' property boolean, Philippe Mathieu-Daudé, 2020/09/12
- Re: [PATCH v2 0/7] hw/char/serial: Housekeeping, no-reply, 2020/09/12
- Re: [PATCH v2 0/7] hw/char/serial: Housekeeping, no-reply, 2020/09/12