[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui: Fix default window_id value
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] ui: Fix default window_id value |
Date: |
Mon, 14 Sep 2020 12:29:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/14/20 12:06 PM, Samuel Thibault wrote:
> ./chardev/baum.c expects the default window_id value to be -1, and not 0
> which could be confused with a proper window id (when numbered from 0 by
> the ui backend).
>
> This fixes getting Braille output with the curses and gtk frontends.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Fixes: f29b3431f62 ("console: move window ID code from baum to sdl")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> ---
> It would be useful to backport this to stable trees.
>
> diff --git a/ui/console.c b/ui/console.c
> index f8d7643fe4..beb733c833 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -1310,6 +1310,7 @@ static QemuConsole *new_console(DisplayState *ds,
> console_type_t console_type,
> }
> s->ds = ds;
> s->console_type = console_type;
> + s->window_id = -1;
>
> if (QTAILQ_EMPTY(&consoles)) {
> s->index = 0;
>