[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iotests: Work around failing readlink -f
From: |
Alex Bennée |
Subject: |
Re: [PATCH] iotests: Work around failing readlink -f |
Date: |
Mon, 14 Sep 2020 13:16:34 +0100 |
User-agent: |
mu4e 1.5.5; emacs 28.0.50 |
Max Reitz <mreitz@redhat.com> writes:
> On macOS, (out of the box) readlink does not have -f. If the recent
> "readlink -f" call introduced by b1cbc33a397 fails, just fall back to
> the old behavior (which means you can run the iotests only from the
> build tree, but that worked fine for six years, so it should be fine
> still).
>
> Keep any potential error message on stderr. If users want to run the
> iotests from outside the build tree, this may point them to what's wrong
> (with their system).
>
> Fixes: b1cbc33a3971b6bb005d5ac3569feae35a71de0f
> ("iotests: Allow running from different directory")
> Reported-by: Claudio Fontana <cfontana@suse.de>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Queued to testing/next, thanks.
--
Alex Bennée