[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/aspeed: Add machine properties to define the flash mo
From: |
Joel Stanley |
Subject: |
Re: [PATCH] hw/arm/aspeed: Add machine properties to define the flash models |
Date: |
Mon, 14 Sep 2020 12:37:21 +0000 |
On Thu, 10 Sep 2020 at 20:07, Cédric Le Goater <clg@kaod.org> wrote:
>
> Some machines don't have much differences a part from the flash model
> being used. Introduce new machine properties to change them from the
> command line.
>
> Cc: 郁雷 <yulei.sh@bytedance.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
A nice feature! Can you add an example command line in the commit message?
We have docs/system/arm/aspeed.rst where we could add the supported
options and some examples of different sized flashes. I know of 16,
32, 64 and 128MB machines out there.
Cheers,
Joel