|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug() |
Date: | Tue, 15 Sep 2020 13:58:53 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
14.09.2020 15:35, Greg Kurz wrote:
As recommended in "qapi/error.h", add a bool return value to spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead of local_err in spapr_memory_plug(). Since object_property_get_uint() only returns 0 on failure, use that as well.
Why are you sure? Can't the property be 0 itself?
Also call ERRP_GUARD() to be able to check the status of void function pc_dimm_plug() with *errp.
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |