[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/11] tests/acpi: add a new unit test to test hotplug off
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v4 02/11] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus |
Date: |
Wed, 16 Sep 2020 08:35:40 +0200 |
On Wed, 16 Sep 2020 11:43:26 +0530
Ani Sinha <ani@anisinha.ca> wrote:
> Ability to turn hotplug off on the pci root bus for i440fx was added in
> commit:
> 3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on
> the root bus")
>
> This change adds a unit test in order to test this feature.
>
> This change has been tested against upstream qemu master branch tip.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
> tests/qtest/bios-tables-test.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 504b810af5..d8c7d57557 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -740,6 +740,20 @@ static void test_acpi_piix4_tcg_bridge(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_piix4_root_hotplug(void)
s/root_hotplug/no_root_hotplug/
or something similar to reflect what test is testing
> +{
> + test_data data;
> +
> + memset(&data, 0, sizeof(data));
> + data.machine = MACHINE_PC;
> + data.variant = ".roothp";
> + data.required_struct_types = base_required_struct_types;
> + data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
> + test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off "
> + "-device pci-bridge,chassis_nr=1", &data);
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg(void)
> {
> test_data data;
> @@ -1144,6 +1158,7 @@ int main(int argc, char *argv[])
> qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis);
> qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
> qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
> + qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);
^^^
no_root_hotplug
> qtest_add_func("acpi/q35", test_acpi_q35_tcg);
> qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
> qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
- [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes., Ani Sinha, 2020/09/16
- [PATCH v4 01/11] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off, Ani Sinha, 2020/09/16
- [PATCH v4 02/11] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus, Ani Sinha, 2020/09/16
- Re: [PATCH v4 02/11] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus,
Igor Mammedov <=
- [PATCH v4 03/11] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off, Ani Sinha, 2020/09/16
- [PATCH v4 04/11] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus, Ani Sinha, 2020/09/16
- [PATCH v4 05/11] i440fx/acpi: do not add hotplug related amls for cold plugged bridges, Ani Sinha, 2020/09/16
- [PATCH v4 06/11] tests/acpi: list added acpi table binary file for pci bridge hotplug test, Ani Sinha, 2020/09/16
- [PATCH v4 07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag, Ani Sinha, 2020/09/16
- [PATCH v4 08/11] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag, Ani Sinha, 2020/09/16