[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pc
From: |
Thomas Huth |
Subject: |
Re: [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx |
Date: |
Wed, 16 Sep 2020 09:41:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Hi!
On 16/09/2020 08.13, Ani Sinha wrote:
> This change adds a unit test to exercize the case when hotplug is disabled
> both for
exercize ==> exercise
(also in the subject, please)
[...]> diff --git a/tests/qtest/bios-tables-test.c
b/tests/qtest/bios-tables-test.c
> index 7632cfe1be..4c834474ad 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -768,6 +768,21 @@ static void test_acpi_piix4_bridge_hotplug(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_piix4_bridge_root_hotplug(void)
> +{
> + test_data data;
> +
> + memset(&data, 0, sizeof(data));
> + data.machine = MACHINE_PC;
> + data.variant = ".hpbrroot";
You could use:
test data = {
.machine = MACHINE_PC;
.variant = ".hpbrroot";
};
... then you don't need the memset() call anymore.
Thomas
- Re: [PATCH v4 05/11] i440fx/acpi: do not add hotplug related amls for cold plugged bridges, (continued)
- [PATCH v4 06/11] tests/acpi: list added acpi table binary file for pci bridge hotplug test, Ani Sinha, 2020/09/16
- [PATCH v4 07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag, Ani Sinha, 2020/09/16
- [PATCH v4 08/11] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag, Ani Sinha, 2020/09/16
- [PATCH v4 09/11] piix4: don't reserve hw resources when hotplug is off globally, Ani Sinha, 2020/09/16
- [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx, Ani Sinha, 2020/09/16
- [PATCH v4 11/11] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/16
- Re: [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes., Igor Mammedov, 2020/09/16