|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v2 1/2] spice: simplify chardev setup |
Date: | Wed, 16 Sep 2020 11:25:31 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 16/09/20 11:06, Daniel P. Berrangé wrote: >> + /* spice must initialize before chardevs (for spicevmc and spiceport) */ >> + qemu_spice_init(); >> + > I don't think we should be putting this before the '-object' processing too. > We really want -object to be the first thing processed in general. > What about making qemu_spice_init() idempotent (i.e. "static bool false = true; if (!first) return; first = false;") and calling it from the spicevmc and spiceport creation function? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |