[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE |
Date: |
Thu, 17 Sep 2020 09:47:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/16/20 8:25 PM, Eduardo Habkost wrote:
> The requirement to specify the parent class type makes the macro
> harder to use and easy to misuse (silent bugs can be introduced
> if the wrong struct type is specified).
>
> Simplify the macro by just not declaring any class struct,
> allowing us to remove the class_size field from the TypeInfo
> variables for those types.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> include/authz/list.h | 2 +-
> include/authz/listfile.h | 2 +-
> include/authz/pamacct.h | 2 +-
> include/authz/simple.h | 2 +-
> include/crypto/secret_keyring.h | 2 +-
> include/io/dns-resolver.h | 2 +-
> include/io/net-listener.h | 2 +-
> include/qom/object.h | 16 ++++++++--------
> include/sysemu/vhost-user-backend.h | 2 +-
> authz/list.c | 1 -
> authz/listfile.c | 1 -
> authz/pamacct.c | 1 -
> authz/simple.c | 1 -
> backends/dbus-vmstate.c | 3 +--
> backends/vhost-user.c | 1 -
> crypto/secret_keyring.c | 1 -
> io/dns-resolver.c | 1 -
> io/net-listener.c | 1 -
> ui/input-barrier.c | 3 +--
> ui/input-linux.c | 3 +--
> 20 files changed, 19 insertions(+), 30 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH 0/5] qom: Convert more declarations to OBJECT_DECLARE*, Eduardo Habkost, 2020/09/16
- [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE, Eduardo Habkost, 2020/09/16
- Re: [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE,
Philippe Mathieu-Daudé <=
- [PATCH 1/5] scripts/codeconverter: Update to latest version, Eduardo Habkost, 2020/09/16
- [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros, Eduardo Habkost, 2020/09/16
- Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros, Thomas Huth, 2020/09/17
- Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros, Igor Mammedov, 2020/09/17
- Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros, Cédric Le Goater, 2020/09/17
- Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros, Cornelia Huck, 2020/09/17
- RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros, Paul Durrant, 2020/09/17
- [PATCH 4/5] [automated] Use OBJECT_DECLARE_TYPE when possible, Eduardo Habkost, 2020/09/16