|
From: | Alberto Garcia |
Subject: | Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps |
Date: | Thu, 17 Sep 2020 16:50:22 +0200 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 09 Sep 2020 08:59:27 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> [...] > -void qcow2_store_persistent_dirty_bitmaps(BlockDriverState *bs, > +bool qcow2_store_persistent_dirty_bitmaps(BlockDriverState *bs, > bool release_stored, Error **errp) > { > + ERRP_GUARD(); This needs an explanation. Berto
[Prev in Thread] | Current Thread | [Next in Thread] |