[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: xenguest is not used so is not needed
From: |
Michael Tokarev |
Subject: |
Re: [PATCH] xen: xenguest is not used so is not needed |
Date: |
Sat, 19 Sep 2020 13:52:30 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
[ https://patchwork.kernel.org/patch/11686919/ ]
Ping? This patch got lost somewhere. Should I try to apply it via trivial tree?
I've more cleanups pending for this area. Just in case, I verified this patch
it wih xen 4.4 and with current xen, and with current qemu, - no part of qemu
uses xenguest interface.
Thanks,
/mjt
27.07.2020 18:20, Michael Tokarev wrote:
> 27.07.2020 18:09, Anthony PERARD wrote:
>> On Mon, Jul 27, 2020 at 05:00:48PM +0300, Michael Tokarev wrote:
>>> There's no references in only file which includes xenguest.h
>>> to any xen definitions. And there's no references to -lxenguest
>>> in qemu, either. Drop it.
>>
>> I'm not sure what you mean by "no references to -lxenguest", do you mean
>> in the binary?
>
> Yes, in the qemu-system-i386 binary, it can be linked without -lxenguest.
>
> Just a caveat, -- I know almost nothing about xen, especially xen
> internals and its (stable, unversioned and unstable, versioned) libs.
> Qemu links fine without libxenguest in the mix with xen 4.11.4, - I
> can't say for other versions. I just thought if it does not include
> <xenguest.h>, why it should link with -lxenguest? :)
- Re: [PATCH] xen: xenguest is not used so is not needed,
Michael Tokarev <=