[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/17] Trivial branch for 5.2 patches
From: |
no-reply |
Subject: |
Re: [PULL 00/17] Trivial branch for 5.2 patches |
Date: |
Sat, 19 Sep 2020 12:10:20 -0700 (PDT) |
Patchew URL:
20200919184451.2129349-1-laurent@vivier.eu/">https://patchew.org/QEMU/20200919184451.2129349-1-laurent@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200919184451.2129349-1-laurent@vivier.eu
Subject: [PULL 00/17] Trivial branch for 5.2 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200919184451.2129349-1-laurent@vivier.eu ->
patchew/20200919184451.2129349-1-laurent@vivier.eu
Switched to a new branch 'test'
6f9951a contrib/: fix some comment spelling errors
5d3d5a1 qapi/: fix some comment spelling errors
1ad31f2 disas/: fix some comment spelling errors
c5980ac linux-user/: fix some comment spelling errors
5779f24 util/: fix some comment spelling errors
418cb9d scripts/: fix some comment spelling errors
1ab9555 docs/: fix some comment spelling errors
cf7f2f5 migration/: fix some comment spelling errors
0b8aa37 qemu/: fix some comment spelling errors
94f4908 scripts/git.orderfile: Display meson files along with buildsys ones
84659a7 hw/timer/hpet: Fix debug format strings
f591d41 hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw
0ec7442 manual: escape backslashes in "parsed-literal" blocks
c0be395 ui/spice-input: Remove superfluous forward declaration
4066166 hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition
a5f3515 hw/gpio/max7310: Remove impossible check
=== OUTPUT BEGIN ===
1/16 Checking commit a5f3515e9187 (hw/gpio/max7310: Remove impossible check)
2/16 Checking commit 40661664b027 (hw/ppc/ppc4xx_pci: Replace magic value by
the PCI_NUM_PINS definition)
3/16 Checking commit c0be3951e528 (ui/spice-input: Remove superfluous forward
declaration)
4/16 Checking commit 0ec7442ca655 (manual: escape backslashes in
"parsed-literal" blocks)
5/16 Checking commit f591d4145830 (hw/timer/hpet: Remove unused functions
hpet_ram_readb, hpet_ram_readw)
6/16 Checking commit 84659a741320 (hw/timer/hpet: Fix debug format strings)
7/16 Checking commit 94f49083a57c (scripts/git.orderfile: Display meson files
along with buildsys ones)
8/16 Checking commit 0b8aa371b9fd (qemu/: fix some comment spelling errors)
WARNING: line over 80 characters
#52: FILE: audio/audio.c:1677:
+ * the same configuration (except the driver), so it doesn't matter
which
WARNING: Block comments use a leading /* on a separate line
#156: FILE: scsi/pr-manager-helper.c:130:
+ /* A simple feature negotiation protocol, even though there is
total: 0 errors, 2 warnings, 88 lines checked
Patch 8/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit cf7f2f519156 (migration/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#96: FILE: migration/postcopy-ram.h:164:
+/* Call each of the shared 'waker's registered telling them of
WARNING: Block comments use a trailing */ on a separate line
#198: FILE: migration/savevm.c:2798:
+ * successful live migration */
total: 0 errors, 2 warnings, 144 lines checked
Patch 9/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/16 Checking commit 1ab9555a0bad (docs/: fix some comment spelling errors)
11/16 Checking commit 418cb9d78050 (scripts/: fix some comment spelling errors)
12/16 Checking commit 5779f24a9c25 (util/: fix some comment spelling errors)
13/16 Checking commit c5980acaeb8b (linux-user/: fix some comment spelling
errors)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: linux-user/aarch64/signal.c:81:
+ /* The actual SVE data immediately follows. It is laid out
WARNING: Block comments use a leading /* on a separate line
#39: FILE: linux-user/cris/target_syscall.h:7:
+/* pt_regs not only specifies the format in the user-struct during
ERROR: code indent should never use tabs
#61: FILE: linux-user/flat.h:46:
+^Iabi_ulong filler[5]; /* Reserved, set to zero */$
total: 1 errors, 2 warnings, 72 lines checked
Patch 13/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/16 Checking commit 1ad31f2af26f (disas/: fix some comment spelling errors)
ERROR: code indent should never use tabs
#26: FILE: disas/hppa.c:2024:
+^I^I /* 'fA' will not generate a space before the register$
WARNING: Block comments use a leading /* on a separate line
#26: FILE: disas/hppa.c:2024:
+ /* 'fA' will not generate a space before the register
ERROR: code indent should never use tabs
#79: FILE: disas/ppc.c:5229:
+^I number of ones, followed by some number of zeros. */$
WARNING: Block comments use a trailing */ on a separate line
#79: FILE: disas/ppc.c:5229:
+ number of ones, followed by some number of zeros. */
total: 2 errors, 2 warnings, 48 lines checked
Patch 14/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/16 Checking commit 5d3d5a19562d (qapi/: fix some comment spelling errors)
16/16 Checking commit 6f9951a0c75c (contrib/: fix some comment spelling errors)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20200919184451.2129349-1-laurent@vivier.eu/testing.checkpatch/?type=message">http://patchew.org/logs/20200919184451.2129349-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PULL 07/17] hw/timer/hpet: Fix debug format strings, (continued)
- [PULL 07/17] hw/timer/hpet: Fix debug format strings, Laurent Vivier, 2020/09/19
- [PULL 12/17] scripts/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 09/17] qemu/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 16/17] qapi/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 13/17] util/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 17/17] contrib/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 11/17] docs/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 15/17] disas/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 14/17] linux-user/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- [PULL 10/17] migration/: fix some comment spelling errors, Laurent Vivier, 2020/09/19
- Re: [PULL 00/17] Trivial branch for 5.2 patches,
no-reply <=
- Re: [PULL 00/17] Trivial branch for 5.2 patches, Peter Maydell, 2020/09/22