[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO
From: |
Paolo Bonzini |
Subject: |
Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO |
Date: |
Sun, 20 Sep 2020 09:56:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 08/09/20 18:41, Li Qiang wrote:
> Currently the qemu device fuzzer find some DMA to MMIO issue. If the
> device handling MMIO currently trigger a DMA which the address is MMIO,
> this will reenter the device MMIO handler. As some of the device doesn't
> consider this it will sometimes crash the qemu.
>
> This patch tries to solve this by adding a per-device flag 'in_mmio'.
> When the memory core dispatch MMIO it will check/set this flag and when
> it leaves it will clean this flag.
>
>
> Li Qiang (4):
> memory: add memory_region_init_io_with_dev interface
> memory: avoid reenter the device's MMIO handler while processing MMIO
> e1000e: use the new memory_region_init_io_with_dev interface
> hcd-xhci: use the new memory_region_init_io_with_dev interface
>
> hw/net/e1000e.c | 8 ++++----
> hw/usb/hcd-xhci.c | 25 ++++++++++++++---------
> include/exec/memory.h | 9 +++++++++
> include/hw/qdev-core.h | 1 +
> softmmu/memory.c | 46 +++++++++++++++++++++++++++++++++++++++---
> 5 files changed, 72 insertions(+), 17 deletions(-)
>
I don't think this is a good solution. These are device bugs and they
need to be fixed.
Paolo
- Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, (continued)
- Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, Gerd Hoffmann, 2020/09/09
- Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, Li Qiang, 2020/09/09
- Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, Alexander Bulekov, 2020/09/09
- Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, Li Qiang, 2020/09/10
- Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, Jason Wang, 2020/09/13
Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface, Paolo Bonzini, 2020/09/20
[RFC 2/4] memory: avoid reenter the device's MMIO handler while processing MMIO, Li Qiang, 2020/09/08
[RFC 4/4] hcd-xhci: use the new memory_region_init_io_with_dev interface, Li Qiang, 2020/09/08
Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO, Jason Wang, 2020/09/08
Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO,
Paolo Bonzini <=