[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer
From: |
no-reply |
Subject: |
Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer |
Date: |
Sun, 20 Sep 2020 20:46:02 -0700 (PDT) |
Patchew URL: 20200921022506.873303-1-alxndr@bu.edu/">https://patchew.org/QEMU/20200921022506.873303-1-alxndr@bu.edu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200921022506.873303-1-alxndr@bu.edu
Subject: [PATCH v3 00/16] Add a General Virtual Device Fuzzer
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200921022506.873303-1-alxndr@bu.edu ->
patchew/20200921022506.873303-1-alxndr@bu.edu
Switched to a new branch 'test'
08f9672 fuzz: Add instructions for using general-fuzz
410c8be scripts/oss-fuzz: Add crash trace minimization script
8e0abed scripts/oss-fuzz: Add script to reorder a general-fuzzer trace
7513795 scripts/oss-fuzz: build the general-fuzzer configs
05353cf scripts/oss-fuzz: Add general-fuzzer configs for oss-fuzz
7abda11 scripts/oss-fuzz: Add general-fuzzer build script
6261e77 scripts/oss-fuzz: Add wrapper program for generic fuzzer
29fd853 fuzz: add a crossover function to generic-fuzzer
f69413a fuzz: add a DISABLE_PCI op to general-fuzzer
7013ef0 fuzz: Add support for custom crossover functions
230a7bd fuzz: Add fuzzer callbacks to DMA-read functions
e713ca2 fuzz: Declare DMA Read callback function
0fb3331 fuzz: Add DMA support to the generic-fuzzer
585e6f0 fuzz: Add PCI features to the general fuzzer
44bac90 fuzz: Add general virtual-device fuzzer
d68075b memory: Add FlatView foreach function
=== OUTPUT BEGIN ===
1/16 Checking commit d68075b23fc3 (memory: Add FlatView foreach function)
2/16 Checking commit 44bac90b4413 (fuzz: Add general virtual-device fuzzer)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 505 lines checked
Patch 2/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/16 Checking commit 585e6f0153b5 (fuzz: Add PCI features to the general fuzzer)
4/16 Checking commit 0fb3331d35db (fuzz: Add DMA support to the generic-fuzzer)
ERROR: externs should be avoided in .c files
#84: FILE: tests/qtest/fuzz/general_fuzz.c:120:
+void fuzz_dma_read_cb(size_t addr, size_t len, MemoryRegion *mr, bool
is_write);
total: 1 errors, 0 warnings, 247 lines checked
Patch 4/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/16 Checking commit e713ca2fcd7d (fuzz: Declare DMA Read callback function)
6/16 Checking commit 230a7bdf81ad (fuzz: Add fuzzer callbacks to DMA-read
functions)
7/16 Checking commit 7013ef029b3d (fuzz: Add support for custom crossover
functions)
8/16 Checking commit f69413a4bf8f (fuzz: add a DISABLE_PCI op to general-fuzzer)
9/16 Checking commit 29fd85365df7 (fuzz: add a crossover function to
generic-fuzzer)
10/16 Checking commit 6261e7752953 (scripts/oss-fuzz: Add wrapper program for
generic fuzzer)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 40 lines checked
Patch 10/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/16 Checking commit 7abda1159bd0 (scripts/oss-fuzz: Add general-fuzzer build
script)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100755
WARNING: line over 80 characters
#57: FILE: scripts/oss-fuzz/build_general_fuzzers.py:36:
+ fuzz_args=str_to_c_byte_array(cfg["args"].replace("\n", "
")),
WARNING: line over 80 characters
#58: FILE: scripts/oss-fuzz/build_general_fuzzers.py:37:
+ fuzz_objs=str_to_c_byte_array(cfg["objects"].replace("\n",
" ")),
total: 0 errors, 3 warnings, 69 lines checked
Patch 11/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/16 Checking commit 05353cfded4a (scripts/oss-fuzz: Add general-fuzzer
configs for oss-fuzz)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 103 lines checked
Patch 12/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/16 Checking commit 7513795c708f (scripts/oss-fuzz: build the general-fuzzer
configs)
14/16 Checking commit 8e0abed9fb55 (scripts/oss-fuzz: Add script to reorder a
general-fuzzer trace)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100755
total: 0 errors, 1 warnings, 94 lines checked
Patch 14/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/16 Checking commit 410c8be1d76e (scripts/oss-fuzz: Add crash trace
minimization script)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100755
total: 0 errors, 1 warnings, 157 lines checked
Patch 15/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/16 Checking commit 08f967285a5d (fuzz: Add instructions for using
general-fuzz)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20200921022506.873303-1-alxndr@bu.edu/testing.checkpatch/?type=message">http://patchew.org/logs/20200921022506.873303-1-alxndr@bu.edu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v3 11/16] scripts/oss-fuzz: Add general-fuzzer build script, (continued)
- [PATCH v3 11/16] scripts/oss-fuzz: Add general-fuzzer build script, Alexander Bulekov, 2020/09/20
- [PATCH v3 13/16] scripts/oss-fuzz: build the general-fuzzer configs, Alexander Bulekov, 2020/09/20
- [PATCH v3 14/16] scripts/oss-fuzz: Add script to reorder a general-fuzzer trace, Alexander Bulekov, 2020/09/20
- [PATCH v3 15/16] scripts/oss-fuzz: Add crash trace minimization script, Alexander Bulekov, 2020/09/20
- [PATCH v3 12/16] scripts/oss-fuzz: Add general-fuzzer configs for oss-fuzz, Alexander Bulekov, 2020/09/20
- [PATCH v3 16/16] fuzz: Add instructions for using general-fuzz, Alexander Bulekov, 2020/09/20
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/20
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/20
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/20
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/20
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer,
no-reply <=
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/21
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/21
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/21
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/21
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/21
- Re: [PATCH v3 00/16] Add a General Virtual Device Fuzzer, no-reply, 2020/09/21