[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] spice: remove obsolete callback
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH] spice: remove obsolete callback |
Date: |
Mon, 21 Sep 2020 10:02:27 +0200 |
Hi,
> Fix compiler deprecation warnings with Spice > 0.14.3 (not released
> yet). We may want to wait until newer version is actually released to
> apply the patch.
Probably makes sense, just in case. It's not like this is an urgent
fix.
> +#if SPICE_SERVER_VERSION < 0x000e04 /* release 0.14.4 */
> static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker)
> {
> PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);
>
> trace_qxl_interface_attach_worker(qxl->id);
> }
> +#endif
> +#if SPICE_SERVER_VERSION < 0x000e04 /* release 0.14.4 */
> static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker)
> {
> /* nothing to do */
> }
> +#endif
While being at it, can we also drop one of the dummy callbacks?
The tracepoint can go away too I think, given qemu doesn't do anything
in the callback anyway.
> +#if SPICE_SERVER_VERSION < 0x000e04 /* release 0.14.4 */
> .attache_worker = interface_attach_worker,
> +#endif
> .set_compression_level = interface_set_compression_level,
> #if SPICE_NEEDS_SET_MM_TIME
> .set_mm_time = interface_set_mm_time,
Add a SPICE_NEEDS_ATTACH_WORKER #define for consistency?
take care,
Gerd