|
From: | Alex Bennée |
Subject: | Re: [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code |
Date: | Mon, 21 Sep 2020 20:29:45 +0100 |
User-agent: | mu4e 1.5.5; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes: > Instead of creating GStrings and passing them into log_disas, > just print the annotations directly in tb_gen_code. > > Fix the annotations for the slow paths of the TB, after the > part implementing the final guest instruction. > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> I guess what we loose in the inline annotation we gain in simpler code. We can always grep stuff out of the logs if we need to: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |