[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 29/38] qapi/gen.py: delint with pylint
From: |
John Snow |
Subject: |
[PATCH v2 29/38] qapi/gen.py: delint with pylint |
Date: |
Tue, 22 Sep 2020 17:00:52 -0400 |
'fp' and 'fd' are self-evident in context, add them to the list of OK
names.
_top and _bottom also need to stay class methods because some users
override the method and need to use `self`. Tell pylint to shush.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/gen.py | 2 ++
scripts/qapi/pylintrc | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index cf340e66d4..ed498397ad 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -50,9 +50,11 @@ def get_content(self) -> str:
return self._top() + self._preamble + self._body + self._bottom()
def _top(self) -> str:
+ # pylint: disable=no-self-use
return ''
def _bottom(self) -> str:
+ # pylint: disable=no-self-use
return ''
def write(self, output_dir: str) -> None:
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index 7438806096..de132d03cf 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -5,7 +5,6 @@
ignore-patterns=doc.py,
error.py,
expr.py,
- gen.py,
parser.py,
schema.py,
types.py,
@@ -46,7 +45,9 @@ good-names=i,
k,
ex,
Run,
- _
+ _,
+ fp, # fp = open(...)
+ fd, # fd = os.open(...)
[VARIABLES]
--
2.26.2
[PATCH v2 29/38] qapi/gen.py: delint with pylint,
John Snow <=
[PATCH v2 10/38] qapi/common.py: delint with pylint, John Snow, 2020/09/22
[PATCH v2 27/38] qapi/gen.py: Remove unused parameter, John Snow, 2020/09/22