[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/38] qapi: add pylintrc
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v2 07/38] qapi: add pylintrc |
Date: |
Tue, 22 Sep 2020 17:54:49 -0400 |
On Tue, Sep 22, 2020 at 05:00:30PM -0400, John Snow wrote:
> Using `pylint --generate-rcfile > pylintrc`, generate a skeleton
> pylintrc file. Sections that are not presently relevant (by the end of
> this series) are removed leaving just the empty section as a search
> engine / documentation hint to future authors.
>
> Right now, quite a few modules are ignored as they are known to fail as
> of this commit. modules will be removed from the known-bad list
> throughout this and following series as they are repaired.
>
> Note: Normally, pylintrc would go in the folder above the module, but as
> that folder is shared by many things, it is going inside the module
> folder (for now). Due to a bug in pylint 2.5.x, pylint does not
> correctly recognize when it is being run from "inside" a package, and
> must be run *outside* of the package.
>
> Therefore, to run it, you must:
>
> > pylint scripts/qapi/ --rcfile=scripts/qapi/pylintrc
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Tested-by: Eduardo Habkost <ehabkost@redhat.com>
This doesn't generate any warnings after this patch, but at the
end of your -pt6 branch I got some pylint warnings. I am
bisecting it to try to identify the patch where the warnings are
introduced.
--
Eduardo
[PATCH v2 09/38] qapi/common.py: Add indent manager, John Snow, 2020/09/22