[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/25] qapi/schema.py: add assert in stub methods
From: |
John Snow |
Subject: |
[PATCH 03/25] qapi/schema.py: add assert in stub methods |
Date: |
Tue, 22 Sep 2020 18:44:39 -0400 |
Instead of pass (an implicit return none), use raise NotImplementedError
to mark a function as abstract -- one that doesn't return. This allows
us to correctly type the stub.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/schema.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 0201b42095..a53631e660 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -176,8 +176,8 @@ def visit(self, visitor):
class QAPISchemaType(QAPISchemaEntity):
# Return the C type for common use.
# For the types we commonly box, this is a pointer type.
- def c_type(self):
- pass
+ def c_type(self) -> str:
+ raise NotImplementedError()
# Return the C type to be used in a parameter list.
def c_param_type(self):
@@ -187,8 +187,8 @@ def c_param_type(self):
def c_unboxed_type(self):
return self.c_type()
- def json_type(self):
- pass
+ def json_type(self) -> str:
+ raise NotImplementedError()
def alternate_qtype(self):
json2qtype = {
--
2.26.2
- [PATCH 00/25] qapi: static typing conversion, pt6, John Snow, 2020/09/22
- [PATCH 01/25] qapi/schema: add Visitable mixin, John Snow, 2020/09/22
- [PATCH 03/25] qapi/schema.py: add assert in stub methods,
John Snow <=
- [PATCH 02/25] qapi/schema.py: Move meta-type into class instances, John Snow, 2020/09/22
- [PATCH 04/25] qapi/schema.py: constrain QAPISchemaObjectType base type, John Snow, 2020/09/22
- [PATCH 06/25] qapi/schema.py: constrain QAPISchemaEvent arg_type type, John Snow, 2020/09/22
- [PATCH 05/25] qapi/schema.py: constrain QAPISchemaObjectTypeMember arg_type type, John Snow, 2020/09/22
- [PATCH 09/25] qapi/schema.py: remove superfluous assert, John Snow, 2020/09/22
- [PATCH 07/25] qapi/schema.py: constrain tag_member type, John Snow, 2020/09/22
- [PATCH 14/25] qapi/schema.py: Assert variants of an object are also objects, John Snow, 2020/09/22
- [PATCH 10/25] qapi/schema.py: Add assertion to ifcond property, John Snow, 2020/09/22
- [PATCH 21/25] qapi/schema.py: disable pylint line limit, John Snow, 2020/09/22
- [PATCH 12/25] qapi/schema.py: remove 'and' from non-bool rvalue expressions, John Snow, 2020/09/22