[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bios-tables-test: Remove kernel-irqchip=off option
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] bios-tables-test: Remove kernel-irqchip=off option |
Date: |
Wed, 23 Sep 2020 04:46:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 22/09/20 21:47, Eduardo Habkost wrote:
> We don't need to use kernel-irqchip=off for irq0 override if IRQ
> routing is supported by the host, which is the case since 2009
> (IRQ routing was added to KVM in Linux v2.6.30).
>
> This is a more straightforward fix for Launchpad bug #1896263, as
> it doesn't require increasing the complexity of the MSR code.
> kernel-irqchip=off is for debugging only and there's no need to
> increase the complexity of the code just to work around an issue
> that was already fixed in the kernel.
>
> Fixes: https://bugs.launchpad.net/bugs/1896263
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index a9c8d478aee..27e8f0a1cb7 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -663,8 +663,7 @@ static void test_acpi_one(const char *params, test_data
> *data)
> data->uefi_fl1, data->uefi_fl2, data->cd, params ? params : "");
>
> } else {
> - /* Disable kernel irqchip to be able to override apic irq0. */
> - args = g_strdup_printf("-machine %s,kernel-irqchip=off %s -accel tcg
> "
> + args = g_strdup_printf("-machine %s %s -accel tcg "
> "-net none -display none %s "
> "-drive id=hd0,if=none,file=%s,format=raw "
> "-device %s,drive=hd0 ",
>
Queued, thanks.
Paolo