[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] virtio: vdpa: omit check return of g_malloc
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] virtio: vdpa: omit check return of g_malloc |
Date: |
Wed, 23 Sep 2020 19:08:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 18/09/2020 à 14:53, Laurent Vivier a écrit :
> On 19/08/2020 16:43, Li Qiang wrote:
>> If g_malloc fails, the application will be terminated.
>> No need to check the return value of g_malloc.
>>
>> Signed-off-by: Li Qiang <liq3ea@163.com>
>> ---
>> hw/virtio/vhost-vdpa.c | 7 +------
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>> index 4580f3efd8..403ae3ae07 100644
>> --- a/hw/virtio/vhost-vdpa.c
>> +++ b/hw/virtio/vhost-vdpa.c
>> @@ -320,10 +320,8 @@ static int vhost_vdpa_set_config(struct vhost_dev *dev,
>> const uint8_t *data,
>> struct vhost_vdpa_config *config;
>> int ret;
>> unsigned long config_size = offsetof(struct vhost_vdpa_config, buf);
>> +
>> config = g_malloc(size + config_size);
>> - if (config == NULL) {
>> - return -1;
>> - }
>> config->off = offset;
>> config->len = size;
>> memcpy(config->buf, data, size);
>> @@ -340,9 +338,6 @@ static int vhost_vdpa_get_config(struct vhost_dev *dev,
>> uint8_t *config,
>> int ret;
>>
>> v_config = g_malloc(config_len + config_size);
>> - if (v_config == NULL) {
>> - return -1;
>> - }
>> v_config->len = config_len;
>> v_config->off = 0;
>> ret = vhost_vdpa_call(dev, VHOST_VDPA_GET_CONFIG, v_config);
>>
>
> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent